Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports TGUI bot menus #11378

Merged
merged 11 commits into from
Sep 22, 2024
Merged

Ports TGUI bot menus #11378

merged 11 commits into from
Sep 22, 2024

Conversation

aramix273
Copy link
Contributor

@aramix273 aramix273 commented Aug 26, 2024

About The Pull Request

This ports TGUI bot menus from TG:
tgstation/tgstation#62748

Mulebot interface is untouched by this and Atmosbot was done manually by scrapping some code from huge air scrubbers

Some things to be discussed

  • medbots have no bandaging option, which was introduced here Medbots will now bandage bleeding patients #11057 - this is a thing prior to this PR and in the case of beakers, the interface was adjusted to have a control for that as well
  • adding custom icons, tooltips, names and so on would require defining specific components in SimpleBot.tsx - could probably benefit from modularizing bot interface files and/or datumizing the controls instead of using lists
  • seems to be able to unlock emagged bots via interface, maybe it shouldn't
  • consistency between showing either the beaker/tiles loaded or their quantity
  • other TODOs I have yet to remember

Why It's Good For The Game

Replaces old HTML interface with a simpler looking TGUI interface
More options for layout and controls
Can include tooltips to explain what different controls do

Testing Photographs and Procedure

Screenshots&Videos

image

(older video in terms of used icons but showcases compatibility with booting sequence)

medbotTGUI.mp4

Changelog

🆑 Aramix, jlsnow301
add: Bots have received an update to their menus
/:cl:

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Aug 26, 2024
@aramix273
Copy link
Contributor Author

last commit is a successful experiment of packaging more information to be sent from dm to the tgui menu
this way, medibots and floorbots now show what they contain, how much of it and out of the maximum it can hold of said type
image

@aramix273 aramix273 force-pushed the bot-tgui branch 2 times, most recently from ab6ab23 to a3e5861 Compare September 9, 2024 18:25
@aramix273 aramix273 closed this Sep 9, 2024
@aramix273 aramix273 reopened this Sep 9, 2024
@aramix273
Copy link
Contributor Author

summary of goofs upon master branch merge fiasco:

  • new undesired tags
    image
    out of which administration and github have been since removed
  • unintentional review request from about every maintainer in the repo
    though with at least bacon and kat having TGUI experience, feedback could prove valuable on the arguably non-ideal TGUI part

@PowerfulBacon PowerfulBacon removed the request for review from itsmeow September 13, 2024 19:39
code/modules/mob/living/simple_animal/bot/atmosbot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/bot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/cleanbot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/ed209bot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/firebot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/firebot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/cleanbot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/secbot.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/bot/medbot.dm Outdated Show resolved Hide resolved
@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 22, 2024
Merged via the queue into BeeStation:master with commit b5ca411 Sep 22, 2024
21 checks passed
@aramix273 aramix273 mentioned this pull request Oct 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Mapping DMM Change Sound Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants